impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Date Tue, 20 Sep 2016 17:45:47 GMT
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4479

Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................

IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

The SQL statements generated from COMPUTE INCREMENTAL STATS
did not properly quote identifiers when incrementally updating
the stats for newly added partitions.

Our existing tests did not catch this case because the code paths
for doing the initial stats computation and the incremental stats
computation are different, in particular, the code for generating
the SQL statements.

Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
---
M fe/src/main/java/com/cloudera/impala/catalog/HdfsPartition.java
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
2 files changed, 42 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/4479/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>

Mime
View raw message