impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthew Jacobs ...@cloudera.com>
Subject Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.
Date Tue, 20 Sep 2016 00:10:10 GMT
Yup, sure thing

On Mon, Sep 19, 2016 at 4:54 PM, Henry Robinson <henry@cloudera.com> wrote:
> Sounds good - if it's ok by you, will do in a separate commit since the
> first one is well into GVO-land...
>
> On 19 September 2016 at 16:19, Matthew Jacobs (Code Review)
> <gerrit@cloudera.org> wrote:
>>
>> Matthew Jacobs has posted comments on this change.
>>
>> Change subject: IMPALA-4160: Remove Llama support.
>> ......................................................................
>>
>>
>> Patch Set 5:
>>
>> (3 comments)
>>
>> a few more small things to remove
>>
>> http://gerrit.cloudera.org:8080/#/c/4445/5/testdata/cluster/admin
>> File testdata/cluster/admin:
>>
>> PS5, Line 82: export LLAMA_WEBUI_PORT=1501  # same as default
>> remove
>>
>>
>> PS5, Line 262:     # Escape the first : to workaround
>> https://jira.cloudera.com/browse/CDH-16840
>>              :
>> LLAMA_PORT_MAPPINGS+="$HADOOP_HOSTNAME\\:$DATANODE_PORT="
>>              :
>> LLAMA_PORT_MAPPINGS+="$HADOOP_HOSTNAME:$NODEMANAGER_PORT
>> We can probably remove these
>>
>>
>> PS5, Line 266: LLAMA_PORT_MAPPINGS
>> this too
>>
>>
>> --
>> To view, visit http://gerrit.cloudera.org:8080/4445
>> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>>
>> Gerrit-MessageType: comment
>> Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef
>> Gerrit-PatchSet: 5
>> Gerrit-Project: Impala-ASF
>> Gerrit-Branch: master
>> Gerrit-Owner: Henry Robinson <henry@cloudera.com>
>> Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
>> Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
>> Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
>> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
>> Gerrit-HasComments: Yes
>
>
>
>
> --
> Henry Robinson
> Software Engineer
> Cloudera
> 415-994-6679

Mime
View raw message