impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load
Date Fri, 30 Sep 2016 17:06:10 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load

Patch Set 5:

File be/src/rpc/TAcceptQueueServer.cpp:

PS4, Line 136: SetupCon
> doAccept() isn't a great name (I know it was from my patch!) because this i

PS4, Line 204: rift code 
> connection_handler_pool, or something similar.

PS4, Line 205: texpr int CONNECTION_SE
> This can be defined in this method as a constexpr.
File be/src/rpc/TAcceptQueueServer.h:

PS4, Line 96: New - 
> strange line breaks in this comment.

PS4, Line 97: // up the connection and starting a thread to
> move into .cc file
File be/src/rpc/

PS4, Line 173: ManyConcurrent
> Call this ManyConcurrentConnection or something.

Line 175:   // waiting to be accepted. (IMPALA-4135)
> Mention that this does not always fail. How long does it take to run?
It takes about 2 seconds on my machine.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50e728974ef31a9d49132a0b3f7cde2a4f3356d
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message