impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr
Date Fri, 30 Sep 2016 06:09:46 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr
......................................................................


Patch Set 12:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4389/10/be/src/runtime/buffered-block-mgr.cc
File be/src/runtime/buffered-block-mgr.cc:

Line 1342:   // Encrypt to a temporary buffer since so that the original data is still in
the buffer
> Are blocks really shared across threads like that?  Anyway, fine to leave t
The comment wasn't clear at all - reworded to make it clear that the problem is re-pinning
the block before the write is finished. I think this scenario will be easy to avoid. Probably
wouldn't be too hard to fix here but doesn't seem worth the effort.


http://gerrit.cloudera.org:8080/#/c/4389/10/be/src/runtime/buffered-block-mgr.h
File be/src/runtime/buffered-block-mgr.h:

PS10, Line 255: , we can
              :     /// instead decrypt data i
> I didn't know what this was trying to say until I saw the clearer comment i
Done


PS10, Line 656: 
> is this talking about encrypted_write_buffer_, or something else?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibebe431f69c3c569cbff68171beaa32ef2ab03b6
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message