impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options
Date Wed, 28 Sep 2016 21:46:51 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

done; carry +1

Trying to fix a build blocker here, so I request we avoid the nits any further.

http://gerrit.cloudera.org:8080/#/c/4555/1/tests/comparison/cli_options.py
File tests/comparison/cli_options.py:

PS1, Line 89: 
> Maybe rename this to parser here and elsewhere to be consistent with add_mi
Done


http://gerrit.cloudera.org:8080/#/c/4555/2/tests/comparison/cli_options.py
File tests/comparison/cli_options.py:

Line 115: 
> Nit: use DEFAULT_HIVE_USER and DEFAULT_HIVE_PASSWORD instead of the raw str
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stakiar@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message