impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) Add downloads page
Date Tue, 27 Sep 2016 21:32:34 GMT
Jim Apple has posted comments on this change.

Change subject: Add downloads page
......................................................................


Patch Set 4:

(5 comments)

I used

    tidy -indent --wrap 90 -bare

in PS1, FYI.

http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html
File downloads.html:

PS1, Line 50: /* Cu
> indent off
Done


PS1, Line 90:   </scrip
> can you align this with <script> ?
Done


Line 141:           <div class="span12">
> Would be nicer looking to have a blank line here.
Added title on separate line.


PS1, Line 159: sign
> This one and the <hr> at line 162 seem to duplicate or is it how we usually
half the time it's two <hr>s, half one.

I made this one one.


http://gerrit.cloudera.org:8080/#/c/4544/1/impala-docs.html
File impala-docs.html:

PS1, Line 48:     
> tab
removed


-- 
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message