impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests
Date Tue, 27 Sep 2016 15:48:24 GMT
Hello Internal Jenkins, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4531

to look at the new patch set (#2).

Change subject: IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests
......................................................................

IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests

The TestEnv used for the backend tests does not connect up the
MemTracker hierarchy in the expected way. This caused the valid
DCHECK in ConsumeLocal() to be triggered in backend tests.

This change fixes TestEnv to set up MemTrackers with the normal
hierarchy, as shown below, and fixes the tests to deal with the fallout
of that.

(Process)
 |
(Query)----------
 |              |
(Block Mgr) (Fragment instance)

Change-Id: Iadcbe96a9f1bf19872436211b049cebf39b0afe7
---
M be/src/exec/hash-table-test.cc
M be/src/runtime/buffered-block-mgr-test.cc
M be/src/runtime/buffered-block-mgr.h
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/mem-tracker.h
M be/src/runtime/test-env.cc
M be/src/runtime/test-env.h
7 files changed, 135 insertions(+), 119 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/4531/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iadcbe96a9f1bf19872436211b049cebf39b0afe7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>

Mime
View raw message