impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions
Date Sat, 24 Sep 2016 11:02:54 GMT
stakiar@cloudera.com has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4419/7/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

Line 1214:         self.profile.is_non_equality_join_predicate(sig.func)]
> This if statement should be above line 1211 and line 1211 should go into th
Done


PS7, Line 1216: join
> there should a 4 space indentation here
Done


PS7, Line 1356: allowed_si
> I think it would be clearer if this was renamed to allowed_signatures
Done


Line 1442:         signature = self.profile.choose_relational_func_signature(relational_signatures)
> I like this. This means that we are not calling the only_use_equality_join_
Yeah, only_use_equality_join_predicates() is never called inside _create_boolean_func_tree()
which I think makes more sense since _create_boolean_func_tree() should be agnostic to whether
or not it is being used to create a join predicate.


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stakiar@cloudera.com
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: stakiar@cloudera.com
Gerrit-HasComments: Yes

Mime
View raw message