impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings
Date Fri, 23 Sep 2016 23:04:56 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings
......................................................................


Patch Set 6:

(4 comments)

Thank you. Please see PS6.

http://gerrit.cloudera.org:8080/#/c/4528/5/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

Line 86: // values contains a list of space-seperated flags.  check to see if the flags we
> now this is only called one place, so you can just inline it there.
Done


Line 90:   int64_t flags = 0;
> Why trim?
Habit, to get rid of any whitespace. It is not needed here, removed it.


PS5, Line 94: 
> " as its first line"
Done


Line 178:   DCHECK(initialized_);
I noticed that setting the governor to performance will set the no_turbo flag back to 0. Should
we mention this here?


-- 
To view, visit http://gerrit.cloudera.org:8080/4528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message