impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings
Date Fri, 23 Sep 2016 22:42:55 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings
......................................................................


Patch Set 5:

(3 comments)

Thanks for the review, please see PS5.

http://gerrit.cloudera.org:8080/#/c/4528/3/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

PS3, Line 86: bool
> Nobody is checking this.
Indeed, fixed it.


PS3, Line 90: (
> The ifstream destructor does this automatically, doesn't it?
It does, removed it here and elsewhere in the file.


PS3, Line 172: 
             : void CpuInfo::VerifyTurboDisabled() {
             :   WarnIfFileNotEqual("/sys/devices/system/cpu/intel_pstate/no_turbo", "1",
             :       "WARNING: CPU turbo is enabled. This setting can change the clock "
             :       "frequency of CPU cores during the benchmark run, which can lead to "
             :       "inaccurate results. You can disable CPU turbo by writing a 1 to"
             :       "/sys/devices/system/cpu/intel_pstate/no_turbo");
             : }
> Even this whole thing can be a helper function now,
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message