impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings
Date Fri, 23 Sep 2016 22:13:44 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4528/3/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

PS3, Line 86: bool
Nobody is checking this.


PS3, Line 90: .
The ifstream destructor does this automatically, doesn't it?


PS3, Line 172: string turbo_file = "/sys/devices/system/cpu/intel_pstate/no_turbo";
             :   string turbo_off;
             :   ReadLine(turbo_file, &turbo_off);
             :   if (turbo_off != "1")
             :     LOG(ERROR) << "WARNING: CPU turbo is enabled. This setting can change
the clock "
             :                << "frequency of CPU cores during the benchmark run, which
can lead to "
             :                << "inaccurate results. You can disable CPU turbo by writing
a 1 to"
             :                << "/sys/devices/system/cpu/intel_pstate/no_turbo";
Even this whole thing can be a helper function now,

    WarnIfFileContents(string filename, string expected, string warning_text)


-- 
To view, visit http://gerrit.cloudera.org:8080/4528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message