impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] WIP: Issue warnings when benchmarks run with sub-optimal system settings
Date Fri, 23 Sep 2016 20:31:33 GMT
Jim Apple has posted comments on this change.

Change subject: WIP: Issue warnings when benchmarks run with sub-optimal system settings
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4528/1//COMMIT_MSG
Commit Message:

PS1, Line 9: This is related to IMPALA-4193 but should probably have its own Jira if
Doesn't this solve that issue?


http://gerrit.cloudera.org:8080/#/c/4528/1/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

PS1, Line 149: ios
This is the default, right?


PS1, Line 151:     if (!governor_file) continue;
             : 
             :     string line;
             :     getline(governor_file, line);
             :     governor_file.close();
             :     trim(line);
This is in the other method, too; can you factor it out?


Line 158:     if (strcmp(line.c_str(), "performance") != 0) {
Can you use a C==-style == here?


Line 172:     if (atoi(line.c_str()) != 1) {
here also, you could compare to "1", right?


Line 173:       LOG(ERROR) << "WARNING: CPU turbo is enabled.";
Explain why this matters - it can ramp-up and down performance dynamically


-- 
To view, visit http://gerrit.cloudera.org:8080/4528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e879cb35cf736f6112c1caed829722a38849794
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message