impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions
Date Fri, 23 Sep 2016 20:18:48 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions
......................................................................


Patch Set 5: -Code-Review

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4419/5/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

Line 1436:         if self.profile.only_use_equality_join_predicates():
> That was my original approach, but this parameter does not fully work. If a
Ok, I see. This means that currency only_use_equality_join_predicates is not functioning correctly.
(There can be non equality join predicates even if only_use_equality_join_predicates is True).
I think the right thing to do is fix it. 

How about adding the following above line 1453 and doing a similar thing to what you are introducing
in this patch:
if self.profile.only_use_equality_join_predicates():

This is not an Impala vs Hive issue. We want to have the option to run the query generator
on Impala with only equality join predicates. It's just that Hive would have this option on
all the time. This option should be controlled in one place, in self.profile.only_use_equality_join_predicates.


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stakiar@cloudera.com
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: stakiar@cloudera.com
Gerrit-HasComments: Yes

Mime
View raw message