impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend
Date Fri, 23 Sep 2016 17:59:35 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances
on a single backend
......................................................................


Patch Set 12:

(4 comments)

Re: testing:
I think a stress test run would be very helpful.
How are the new Mt paths exercised?

http://gerrit.cloudera.org:8080/#/c/4054/10/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS10, Line 294: boost
> a complete overhaul of coordinator.cc is out of scope.
Sure, I just figured it'd be nice to clean up if it were easy.


PS10, Line 2083: rorLogMap merged;
> yes
can you mention that? It's hard to keep track of all the TODOs, it'll make it a bit easier
when we come back to fix some of this.


http://gerrit.cloudera.org:8080/#/c/4054/10/be/src/scheduling/query-schedule.h
File be/src/scheduling/query-schedule.h:

PS10, Line 90:  shared across fragment instances
> not sure what you mean.
This owns the vector of fragment instance exec params, so I think it's confusing that this
is defined as the parameters _shared across frag instances_.

How about something like:
"Execution parameters for the fragment; Includes parameters that are shared across fragment
instances and owns the per-instance FInstanceExecParams."?


http://gerrit.cloudera.org:8080/#/c/4054/12/be/src/scheduling/query-schedule.h
File be/src/scheduling/query-schedule.h:

Line 192:   /// Map node ids to the index of their node inside their plan.nodes list.
TODO-MT: remove, only needed on the ST path


-- 
To view, visit http://gerrit.cloudera.org:8080/4054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message