impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms
Date Fri, 23 Sep 2016 17:35:36 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4187: Switch RPC latency metrics to histograms
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/util/histogram-metric.h
File be/src/util/histogram-metric.h:

PS2, Line 70: id Update(int64_t val) {
> I'm not sure I follow - HdrHistogram is thread-safe (at least per the class
Nvm, looked at it more carefully again, and it is lock-free but thread safe.


-- 
To view, visit http://gerrit.cloudera.org:8080/4516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba6d4270dd5676eeeff35ad8d9dc5dcddd95e34
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message