impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Date Thu, 22 Sep 2016 06:21:20 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/service/child-query.h
File be/src/service/child-query.h:

PS6, Line 170: d prevents any more from starting. 
> What I mean is it'd be better to say that rather than "execution thread has
Done


http://gerrit.cloudera.org:8080/#/c/4163/9/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

Line 434:     // do not set up coordinator.
> rather than explaining what the code does, explain why.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe3024803e03595ee69c47759b58e8443d7bd167
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message