impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late
Date Thu, 22 Sep 2016 05:51:18 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4500/2/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

PS2, Line 638: Don't warn for topic updates 
> I am a bit concerned about not warn topic delay at all. with the log, as le
What do you suggest? The problem I see is that there's no SLA associated with delivering topic
updates, and delivery is pretty variable (initial updates of the full catalog tend to run
slower). So it's not clear what threshold to warn on, and even if action should be taken if
it's just a period of heavy load. 

I think what might be better is to keep a measure of topic update delays like a histogram
so that we can see how topic updates are doing at any time. What do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/4500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message