impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late
Date Thu, 22 Sep 2016 03:04:08 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4500/2/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

PS2, Line 638: Don't warn for topic updates 
I am a bit concerned about not warn topic delay at all. with the log, as least user aware
of the topic delay and they can investigate and do some tuning. and it will explain why a
new created table by Impala not show quickly on another impalad. On large cluster, I have
seen the topic update never able to catch up due to small thread pool.


-- 
To view, visit http://gerrit.cloudera.org:8080/4500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message