impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late
Date Thu, 22 Sep 2016 00:18:00 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4500/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

PS1, Line 630: const string& msg = Substitute(
             :           "Missed subscriber ($0) $1 d
> Ok, although bear in mind that CM references aren't verboten just because t
Oh ok, I assumed CM refs would be out. I'm fine either way then.


-- 
To view, visit http://gerrit.cloudera.org:8080/4500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message