impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches
Date Thu, 22 Sep 2016 00:04:29 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4023: don't attach buffered tuple streams to batches

Patch Set 1:


Changes make a lot of sense to me.
File be/src/runtime/

Line 1185: }
Add a simple test that checks pinned blocks are attached to a non-NULL batch when calling
Close() on the stream.
File be/src/runtime/row-batch.h:

Line 129:   bool ALWAYS_INLINE AtCapacity() {
The meaning of AtCapacity() has slightly changed and I think it might be a problem, but you
can convince me otherwise :)

1. I think we still need to check need_to_return_
2. Before, when attaching a stream to a batch, that batch would always be considered at capacity.
Now we are attaching pinned blocks, but those don't imply AtCapacity(). I'm worried about
running into a scenario where we call GetNext() on an exec node before all those pinned blocks
are  unpinned/freed.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I6471422f86ce71e4c6ab277a276000051bc2e8ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message