impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late
Date Thu, 22 Sep 2016 00:04:26 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4500/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

PS1, Line 630: // TODO: This should be a healthcheck in a monitored metric in CM, which would
             :       // require a 'rate' metric type.
> remove this reference to CM while we're here
Ok, although bear in mind that CM references aren't verboten just because this is an Apache
project. Happy to remove here.


PS1, Line 633: "Missed subscriber ($0) $1 deadline by $2ms, "
             :           "consider increasing --statestore_heartbeat_frequency_ms (currently
$3) on "
             :           "this Statestore and --statestore_subscriber_timeout_seconds "
             :           "on subscribers",
> I'm worried it's too hard to know what value to pick. Do we have any guidan
I don't think there's any good advice out there, nor is there in the docs. At some point I
think we have to say "you figure it out" with these kinds of warning messages, and it's not
helpful necessarily to print a wall of text. A good value is usually a larger one (as recommended),
so users have a chance of improving things because the amount by which deadlines were missed
will go down so there's a feedback loop.


PS1, Line 636: subscribers
> subscribers (Impala Daemons and the Catalog Server)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message