impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late
Date Wed, 21 Sep 2016 23:03:33 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4500/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

PS1, Line 630: // TODO: This should be a healthcheck in a monitored metric in CM, which would
             :       // require a 'rate' metric type.
remove this reference to CM while we're here


PS1, Line 636: subscribers
subscribers (Impala Daemons and the Catalog Server)


PS1, Line 633: "Missed subscriber ($0) $1 deadline by $2ms, "
             :           "consider increasing --statestore_heartbeat_frequency_ms (currently
$3) on "
             :           "this Statestore and --statestore_subscriber_timeout_seconds "
             :           "on subscribers",
I'm worried it's too hard to know what value to pick. Do we have any guidance we can point
to? Or maybe just add "Please consult the Impala documentation for more information."


-- 
To view, visit http://gerrit.cloudera.org:8080/4500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message