impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Date Wed, 21 Sep 2016 22:33:12 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

PS6, Line 246: during
what does this mean? while making RPCs? while servicing RPCs?


http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/service/child-query.cc
File be/src/service/child-query.cc:

Line 220:   return child_queries_thread_.get();
what does holding the lock here prevent? (related to my question about allowed concurrency
of Exec/Wait.


http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/service/child-query.h
File be/src/service/child-query.h:

PS6, Line 161:  by joining
             :   /// 'child_queries_thread_'.
you should explain this without talking about private members.


Line 167:   Status WaitForAll(std::vector<ChildQuery*>* completed_queries);
can this be called by concurrently with ExecAsync() or is that not allowed?


PS6, Line 170: and the execution thread has exited
what does this really mean to the caller? that it can destroy the object? something else?


-- 
To view, visit http://gerrit.cloudera.org:8080/4163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe3024803e03595ee69c47759b58e8443d7bd167
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message