impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.
Date Wed, 21 Sep 2016 22:04:44 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces
visible.
......................................................................


IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

When the Sentry config file contained extra spaces it used to be difficult to
determine what went wrong because the offending path was not quoted making the
spaces hard to see. As a result, Impala startup failed.

This patch quotes the bad file path in the error message to make the extra spaces
visible.

Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634
Reviewed-on: http://gerrit.cloudera.org:8080/4309
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/com/cloudera/impala/authorization/SentryConfig.java
M fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: davyxdh@163.com
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: davyxdh@163.com

Mime
View raw message