impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions
Date Wed, 21 Sep 2016 21:14:58 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4419/4/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

PS4, Line 1369: functions
s/functions/signatures/


http://gerrit.cloudera.org:8080/#/c/4419/4/tests/comparison/tests/hive/test_create_join_clause.py
File tests/comparison/tests/hive/test_create_join_clause.py:

PS4, Line 25: def test_create_equality_only_joins():
Nit: this test is hive-specific, so hive should be in the test name.


PS4, Line 31:   class FakeQueryProfile
FakeHiveQueryProfile


PS4, Line 55:   mock_query_gen = QueryGenerator(FakeQueryProfile())
Nit: This isn't a mock object; it's a real QueryGenerator. I would just call this query_generator.


PS4, Line 60:   right_table.add_col(Column("right_table", "right_col", Int))
Any thoughts on maybe parametrizing this test to test with different types?  It would be pretty
easy to add the parametrization:

  @pytest.mark.parametrize("test_col_type", [Char, Int, # etc. ]
  def test_hive_create_equality_joins(test_col_type):
    # ...
    right_table.add_col(Column("right_table", "right_col", test_col_type)
    # ...

You could also assert that the Equals you're getting back is bound to the expected type.

I mention these things because you get more coverage with very little additional work.


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stakiar@cloudera.com
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: stakiar@cloudera.com
Gerrit-HasComments: Yes

Mime
View raw message