impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions
Date Wed, 21 Sep 2016 20:20:03 GMT
stakiar@cloudera.com has posted comments on this change.

Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions
......................................................................


Patch Set 4:

(6 comments)

@Michael, comments addressed.

http://gerrit.cloudera.org:8080/#/c/4419/3//COMMIT_MSG
Commit Message:

PS3, Line 35: subtle;
> Nit: this is a comma splice. You can change the comma to something like a c
Done


PS3, Line 41: it's
> Nit: "it's"
Done


PS3, Line 45: its 
> Nit: "its" :)
Done


http://gerrit.cloudera.org:8080/#/c/4419/3/tests/comparison/query_generator.py
File tests/comparison/query_generator.py:

Line 1364:          relational_col_types: Can be used to restrict the signature of the chosen
> Add documentation about the signatures parameter.
Done


http://gerrit.cloudera.org:8080/#/c/4419/3/tests/comparison/query_profile.py
File tests/comparison/query_profile.py:

PS3, Line 661: 
             : PROFILES = [var for var in locals().values()
             :             if isinstance(var, type)
> Maybe use an or expression for these two conditions and remove the elif?
Re-wrote this as a single list comprehension


http://gerrit.cloudera.org:8080/#/c/4419/3/tests/comparison/tests/hive/test_create_join_clause.py
File tests/comparison/tests/hive/test_create_join_clause.py:

PS3, Line 31:   class FakeQueryProfile(HiveProfile):
> 1. I prefer "Fake" instead of "Mock". I prefer the use of "mock" only when 
Sounds reasonable, updated


-- 
To view, visit http://gerrit.cloudera.org:8080/4419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: stakiar@cloudera.com
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: stakiar@cloudera.com
Gerrit-HasComments: Yes

Mime
View raw message