impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname
Date Wed, 21 Sep 2016 19:34:55 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4314/1//COMMIT_MSG
Commit Message:

Line 9:   Change format in webserver.cc and add test in webserver-test.cc
Please describe the before and after format. I don't really see hoe the format changed based
on the changes in webserver.cc


http://gerrit.cloudera.org:8080/#/c/4314/1/be/src/util/webserver.cc
File be/src/util/webserver.cc:

Line 238:   stringstream listening_spec;
I don't see how the result of listening_spec has changed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9131c6e47ce8e56eda20e9eb82d68b85de2fa866
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <hewenting_ict@163.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message