impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible.
Date Tue, 20 Sep 2016 02:22:31 GMT
Hello Lars Volker, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4309

to look at the new patch set (#5).

Change subject: IMPALA-4028: Improve message for improper Sentry config file path to  make
extra spaces visible.
......................................................................

IMPALA-4028: Improve message for improper Sentry config file path to 
make extra spaces visible.

When Sentry config file is incorrectly entered,the end contains spaces,
impala starts up failed.

Use quotes to embrace the file path in the error message that will help 
to identify the redundant spaces in the file path.

Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634
---
M fe/src/main/java/com/cloudera/impala/authorization/SentryConfig.java
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/4309/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: davyxdh@163.com
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: davyxdh@163.com

Mime
View raw message