impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4610: Remove Llama support.
Date Mon, 19 Sep 2016 17:53:43 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4610: Remove Llama support.
......................................................................


Patch Set 1:

(4 comments)

Matt's going to weigh in on what parts of the memory estimation path we can remove, depending
on what admission control depends on.

http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/query-schedule.h
File be/src/scheduling/query-schedule.h:

Line 86:   int16_t GetPerHostVCores() const;
> what about this?
This is an unused method declaration.

As discussed, we still use VCores to generate estimates in the plan / profile, and since those
are user-facing we should phase them out on a different schedule. Left a TODO.


http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/request-pool-service.cc
File be/src/scheduling/request-pool-service.cc:

Line 47: DEFINE_string(llama_site_path, "", "Path to the Llama configuration file "
> good to know. please leave todo with explanatory comment.
Done


http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 292
> what's going on here?
The 'offline' mode was used only when the local NodeManager went offline. Since that can't
happen, this is an unused and untested code path. We'll likely want to redo this anyhow when
we implement decommissioning.


http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 243
> unclear how this is related to llama
See other comment wrt when this was used.


-- 
To view, visit http://gerrit.cloudera.org:8080/4445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message