impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity
Date Sat, 17 Sep 2016 00:15:46 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity
......................................................................


Patch Set 4:

(2 comments)

Rebased to include IMPALA_ASSERT_DEBUG_DEATH macro from trunk.

http://gerrit.cloudera.org:8080/#/c/4428/4//COMMIT_MSG
Commit Message:

PS4, Line 11: this is usually calculated from
            : capacity()
> are there places that incorrectly use capacity() that should be changed to 
I have one in my upcoming patch for IMPALA-2905. Independently, this seems like a shortcoming
in the API - there's no way to do AcquireState() after capacity changes without sharing knowledge
of the initial capacity through a separate channel.

Otherwise there are a couple of AcquireState() calls, but they use row batches that have been
initialized with RuntimeState::batch_size() rows.


http://gerrit.cloudera.org:8080/#/c/4428/4/be/src/runtime/row-batch.h
File be/src/runtime/row-batch.h:

PS4, Line 360: capacity_
> not due to your change, but this comment should be fixed.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message