impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database
Date Fri, 16 Sep 2016 16:44:59 GMT has posted comments on this change.

Change subject: IMPALA-3980: qgen: re-enable Hive as a target database

Patch Set 6:

> Uploaded patch set 6.

Hey Michael,

Apologies, yes you are correct, the tests were failing with this patch. It seems my dev setup
wasn't fully setup properly. Originally, I was trying to avoid building Impala fully, so I
made some modifications to get the Python code to run locally. The tests were passing locally,
but I realize this probably isn't a great approach if I want to reliably run these unit tests.
I've set up a proper Impala dev environment on a remote machine. Once I did that I was able
to re-produce the error. The hive-default.xml file under fe/src/test/resources/ is not a valid
XML file. It was missing some element terminators. Once I fixed those the tests starting working.
I have updated the patch.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: No

View raw message