impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <>
Subject [Impala-ASF-CR] Make gen build resilient to a failing git rev-parse
Date Fri, 16 Sep 2016 06:40:28 GMT
Sailesh Mukil has submitted this change and it was merged.

Change subject: Make resilient to a failing git rev-parse

Make resilient to a failing git rev-parse

It was noticed that some build processes did not checkout Impala and
instead built it from a tarball. This would cause our gen_build_version
script to write a blank version info everytime to the file.

This patch takes care of the case where if there is an already existing file and we cannot get the git rev-parse output, we use
the old file instead. Blank version info is written only when we don't
have an old file and we cannot do a git rev-parse.

Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b
Reviewed-by: Sailesh Mukil <>
Tested-by: Sailesh Mukil <>
M bin/
M bin/
2 files changed, 35 insertions(+), 17 deletions(-)

  Sailesh Mukil: Looks good to me, approved; Verified

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Sailesh Mukil <>

View raw message