impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called
Date Thu, 15 Sep 2016 22:09:33 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4428/1/be/src/runtime/row-batch-test.cc
File be/src/runtime/row-batch-test.cc:

Line 38:   vector<bool> nullable_tuples(1, false);
This is ok, but I find the c++11 initialisers for vectors a bit nicer. e.g. nullable_tuples({false})


PS1, Line 39: TTupleId
This should be a static_cast according to our coding standard.


Line 60:     ASSERT_DEBUG_DEATH(bad_dest.AcquireState(&src), "");
> Will change to IMPALA_ASSERT_DEBUG_DEATH when related patch lands.
We should make sure to merge that first, otherwise we will have a lot of core dumps.


http://gerrit.cloudera.org:8080/#/c/4428/1/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:

Line 319:   capacity_ = tuple_ptrs_size_ / (num_tuples_per_row_ * sizeof(Tuple*));
We already know the initial capacity using this calculation - we should compute it the same
way in both places. Maybe just factor this out into an InitialCapacity() function?


-- 
To view, visit http://gerrit.cloudera.org:8080/4428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message