impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu
Date Thu, 15 Sep 2016 17:10:43 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3739: Enable stress tests on Kudu
......................................................................


Patch Set 4:

(3 comments)

I took a look at the TPC-H and DS specs for more primary key inconsistencies. If the discrepancies
are intentional, can you leave a note? (TPCH looked right to my eyes.)

http://gerrit.cloudera.org:8080/#/c/4327/4/testdata/datasets/tpcds/tpcds_kudu_template.sql
File testdata/datasets/tpcds/tpcds_kudu_template.sql:

PS4, Line 263: 'kudu.key_columns'='sr_returned_date_sk,sr_ticket_number, sr_item_sk',
In TPC-DS, the primary keys are sr_item_sk, sr_ticket_number . Is this difference correct
and intentional?


PS4, Line 575: 'kudu.key_columns'='hd_demo_sk,hd_income_band_sk',
In TPC-DS only hd_demo_sk is a primary key.


PS4, Line 643: 'kudu.key_columns'='p_promo_sk, p_item_sk',
In TPC-DS, only p_promo_sk is a primary key.


-- 
To view, visit http://gerrit.cloudera.org:8080/4327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c9fc3dae24b761f031ee8e014bd611a49029d34
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message