impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads
Date Thu, 15 Sep 2016 17:06:01 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3823: Add timer to measure Parquet footer reads

Patch Set 4:

File be/src/util/runtime-profile-counters.h:

PS4, Line 147: .
> When you say 'child counters', do you mean it in the terms of the child cou
Yeah, ignore this. I was trying to further differentiate this from the new counter.

In the future we can think about cleaning up all the different kinds of Counters we have.
File be/src/util/

PS5, Line 1020: }
              : voi
1 line

PS5, Line 1023:   lock_guard<SpinLock> l(counter_lock_);
              :   unit_ = counter.unit;
              :   c
1 line
File tests/query_test/

Line 338:     # scan and process the Parquet footer across scan ranges and also records the
min and
can you add a TODO for handling the case when there is more than one range per node? You can
add it requires parsing the times and there is unit test coverage.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-HasComments: Yes

View raw message