impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu
Date Wed, 14 Sep 2016 20:52:31 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3739: Enable stress tests on Kudu

Patch Set 1:


I'm still reviewing this, but since my name was called out, here are two comments.
File testdata/bin/

PS1, Line 50: with
> Hm, I've seen other scripts (e.g.  already using the same s
It's not clear to me that we have to support python2.4 in test code. If we do, then our test
code is already broken in many, many places. I would prefer to set the floor for test code
at python2.6, which is already inconveniently old. I'm OK to leave this as is.
File tests/stress/

PS1, Line 1382:   if not args.tpcds_db and not args.tpch_db and not args.random_db \
              :       and not args.tpch_nested_db and not args.tpch_kudu_db \
              :       and not args.tpcds_kudu_db and not args.query_file_path:
              :     raise Exception("At least one of --tpcds-db, --tpch-db, --tpch-kudu-db,"
              :         "--tpcds-kudu-db, --tpch-nested-db, --random-db, --query-file-path
is required")
> Hmm cumbersome... Maybe someone with more python experience knows a better 
If not any() should work.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c9fc3dae24b761f031ee8e014bd611a49029d34
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-HasComments: Yes

View raw message