impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu
Date Tue, 13 Sep 2016 20:53:13 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3718: Support subset of functional-query for Kudu
......................................................................


Patch Set 2:

> (8 comments)
 > 
 > Thanks for the feedback.
 > 
 > My thought with xfail was that I wanted them to show up as xfail so
 > we see them and have an incentive to fix them in the future. We
 > should be able to add support for the remaining tables once kudu
 > addresses the JIRAs I mentioned in the commit comment. I can change
 > them to skips if you still prefer.

BTW I forgot to mention, I tested this with an exhaustive test run which completed successfully.

-- 
To view, visit http://gerrit.cloudera.org:8080/4175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iada88e078352e4462745d9a9a1b5111260d21acc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message