impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh
Date Tue, 13 Sep 2016 15:56:32 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4348/6/testdata/bin/check-hbase-nodes.py
File testdata/bin/check-hbase-nodes.py:

PS6, Line 59:                         help=('Comma-delineated string of hosts in host:PORT
format, '
> When is more than one zk host needed?
Don't know, but that's the way the API is written.


PS6, Line 135:     # Confirm that HDFS is available. There is a pathological case where the
HBase master
             :     # can start up briefly if HDFS is not available, and then quit immediately,
but that can
             :     # be long enough to give a false positive that the HBase master is running.
             :     #
             :     try:
             :         hdfs_client = InsecureClient('http://' + args.hdfs_host)
             :         hdfs_client.list('/')
             :     except requests.exceptions.ConnectionError as e:
             :         msg = 'Could not connect to HDFS web host http://{0} - {1}'.format(args.hdfs_host,
e)
             :         LOGGER.error(msg)
             :         sys.exit(1)
             : 
             :     errors = check_znodes_list_for_errors(args.nodes, args.zookeeper_hosts,
args.timeout)
> I meant for this section also to be a method, with errors returned.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4348
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b81f3cfb6ea0ba7b18ce5fcd5d268f515c8b0c3
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message