impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.
Date Tue, 13 Sep 2016 04:02:38 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 2:

(9 comments)

Made a first pass. I'm still building the change to validate it myself.

http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/exec/old-hash-table-test.cc
File be/src/exec/old-hash-table-test.cc:

PS2, Line 23: #include "testutil/gtest-util.h"
Still needed?


PS2, Line 24: #include "common/init.h"
            : #include "common/compiler-util.h"
nit: preserve alphabetical order (here and in other files)


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/exec/parquet-plain-test.cc
File be/src/exec/parquet-plain-test.cc:

PS2, Line 22: #include <gtest/gtest.h>
nit: not needed with the gtest-util import. We could remove this from all other tests, too.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/runtime/buffered-tuple-stream-test.cc
File be/src/runtime/buffered-tuple-stream-test.cc:

PS2, Line 1171: BE_TEST
it was not clear to me why this was set to BE_TEST here, while we also initialize the FE in
the next line. Maybe add an explanation to the comment in common/init.h, or even add an overload
that removes the parameter, since none of the be tests seem to use it.


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/testutil/gtest-util.h
File be/src/testutil/gtest-util.h:

Line 32: // Basic main() function to be used in gtest unit tests. Does not start a JVM
nit: wrap at 90 characters


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/bloom-filter-test.cc
File be/src/util/bloom-filter-test.cc:

PS2, Line 27: #include "common/init.h"
still needed?


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

PS2, Line 22: #include "common/init.h"
It is needed? It's seems to be included in gtest-util.h anyways


http://gerrit.cloudera.org:8080/#/c/4352/2/be/src/util/metrics-test.cc
File be/src/util/metrics-test.cc:

PS2, Line 386: 
I don't think this gets executed anymore, since IMPALA_TEST_MAIN() will set the respective
parameter in InitCommonRuntime to false. Is this change intended? I couldn't tell from the
code in this file.


PS2, Line 26: #include "util/jni-util.h"
not needed anymore?


-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message