impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Date Mon, 12 Sep 2016 21:53:28 GMT
Todd Lipcon has posted comments on this change.

Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................


Patch Set 1:

lgtm, though it might be a good idea to document the reasoning that the "relicense" is OK
in the commit message so that if anyone is auditing the provenance of these files through
git history later, you have some trail of why you decided to replace the license header.

-- 
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: No

Mime
View raw message