impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers
Date Mon, 12 Sep 2016 21:23:51 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4008: don't bake in hash table and hash join pointers

Patch Set 3:

File be/src/exec/hash-table.h:

PS3, Line 300: ExprValuesHash
CurExprValuesHash()  [see below for motiviation]

PS3, Line 303: SetExprValuesHash
Let's rename this to more closely match cur_expr_values() rather than matching ExprValuePtr
(which used to make sense, but now no longer does given that ExprValuePtr doesn't necessarily
operate on "current").


PS3, Line 309: cur_expr_values_null
comment explaining that there is one byte per null value (i.e. these are used as bools, but
typed as uint8_t for codegen).  (to support the arithmetic above).

PS3, Line 403: in
the first time I read this, I read it as this functions stores the values that are in 'expr_values'.
 Let's clarify by saying "to" or "into".

PS3, Line 403: in

PS3, Line 413: in

PS3, Line 431: This will be replaced by
             :   /// codegen.
nit: move this sentence to end of the comment so it's standardized with similar comments and
not buried.

PS3, Line 438: with 'cur_expr_values_'
"to compare against the current row."  (since it also uses cur_expr_values_null and to give
a little more info than what the C code tells us).

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie353666dbb5c958f0094d169306fe930ec3014c5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message