impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.
Date Mon, 12 Sep 2016 21:07:39 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests.
......................................................................


Patch Set 1:

Thanks for fixing this. While we are at it, why don't we create a common library for the tests
containing a default main() function and then just link all tests against it? This way we
could get away with less code and wouldn't need to maintain main() functions in all tests.

-- 
To view, visit http://gerrit.cloudera.org:8080/4352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff0acf09bf192d54baeb0bb347e895fce6ed23b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message