impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
Date Mon, 12 Sep 2016 21:04:15 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Patch Set 1:


 > looks pretty reasonable. Might want to do a surface level
 > understanding of why you need this ratcursive workaround and file a
 > JIRA upstream.

Looks like it was some 0.11 problems; 0.12 worked without ratcursive.
File bin/

PS1, Line 38: RAT_JAR=$1
            : # The location of the Impala directory (or subdirectory within the Impala tree)
to check:
            : START=$2
> rather than relying just on set -u, i think it's nicer to print a real 'usa
File removed.

PS1, Line 51:  PN
> what's PN?

Line 63:                 echo "Failed to RAT ${FN}" >&2
> should set the exit code in this case, no? otherwise people might miss this
I thinkk RAT exits with 0 even when the license isn't OK. I've changed the checker python
script I borrowed from Kudu to be a little stricter in what goes to stderr.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-HasComments: Yes

View raw message