impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads
Date Mon, 12 Sep 2016 18:15:28 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4371/2/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

PS2, Line 343:       # The chance that the times taken by different scan ranges to process
the footer,
             :       # are equal, is very unlikely. However, it could happen which could make
the min and
             :       # max time to process a footer equal. Assert that at a time, no more
than 1 node has
             :       # equal min and max time.
             :       assert num_equal < 2
this seems brittle...

how about checking that:

0 <= min <= avg <= max < total time (e.g. scanner thread wall clock time?)


-- 
To view, visit http://gerrit.cloudera.org:8080/4371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message