impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report
Date Mon, 12 Sep 2016 10:55:32 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4335/3/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

PS3, Line 250:  Fragment
> fragment (no cap). Also space after ":" as Tim suggested.
Done


Line 250:   ss << "Memory Limit Exceeded by Fragment:" << this->fragment_instance_id()
<< endl;
> Let's put a space after :
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb4e0c359d889938b4c351771ba539850bdb95ea
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message