impala-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (JIRA)" <>
Subject [jira] [Created] (IMPALA-5659) glog / gflags should be dynamically linked if Impala is
Date Thu, 13 Jul 2017 19:22:00 GMT
Henry Robinson created IMPALA-5659:

             Summary: glog / gflags should be dynamically linked if Impala is
                 Key: IMPALA-5659
             Project: IMPALA
          Issue Type: Improvement
          Components: Infrastructure
            Reporter: Henry Robinson
            Assignee: Henry Robinson
            Priority: Minor

The glog and gflags libraries are currently always statically linked against Impala, whether
or not BUILD_SHARED_LIBS is true.

However, that can cause a problem if one of our libraries itself tries to link against glog
or gflags: the google library will be linked twice in the final binary, and that causes problems
for these particular libraries that require that they are linked at most once.

The proposed fix is to dynamically link glog and gflags if BUILD_SHARED_LIBS is true. 

This is not an issue in our current code, but making this fix future-proofs us against running
into the problem later (and the kudu util library has this exact issue, as it tries to link
against glog directly).

This message was sent by Atlassian JIRA

View raw message