impala-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sherman (JIRA)" <j...@apache.org>
Subject [jira] [Created] (IMPALA-5432) SetMemLimitExceeded DCHECK no longer valid
Date Sun, 04 Jun 2017 20:56:04 GMT
John Sherman created IMPALA-5432:
------------------------------------

             Summary: SetMemLimitExceeded DCHECK no longer valid
                 Key: IMPALA-5432
                 URL: https://issues.apache.org/jira/browse/IMPALA-5432
             Project: IMPALA
          Issue Type: Bug
          Components: Backend
    Affects Versions: Impala 2.9.0
            Reporter: John Sherman
            Assignee: John Sherman


DCHECK(query_status_.IsMemLimitExceeded()) fails due to conditional setting of MemLimitExceeded
status. The query_status is only set to MemLimitExceeded if the prior status was ok (query_status_.ok).

{code}
void RuntimeState::SetMemLimitExceeded(MemTracker* tracker,
    int64_t failed_allocation_size, const ErrorMsg* msg) {
  Status status = tracker->MemLimitExceeded(this, msg == nullptr ? "" : msg->msg(),
      failed_allocation_size);
  {
    lock_guard<SpinLock> l(query_status_lock_);
    if (query_status_.ok()) query_status_ = status;
  }
  LogError(status.msg());
  // Add warning about missing stats except for compute stats child queries.
  if (!query_ctx().__isset.parent_query_id &&
      query_ctx().__isset.tables_missing_stats &&
      !query_ctx().tables_missing_stats.empty()) {
    LogError(ErrorMsg(TErrorCode::GENERAL,
        GetTablesMissingStatsWarning(query_ctx().tables_missing_stats)));
  }
  DCHECK(query_status_.IsMemLimitExceeded());
}
{code}

This was discovered while running: ./tests/run-tests.py query_test/test_queries.py -k test_very_large_strings
which caused some impalad instances to hit the DCHECK and generate minidumps in my environment
(and fail the test).

Removing the DCHECK still doesn't allow the test to pass due to what I think is better memory
error reporting, but I'm still investigating the failures to better understand what is going
on.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message