impala-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (IMPALA-4622) Support changing Kudu default and storage attributes
Date Fri, 23 Jun 2017 14:29:00 GMT

     [ https://issues.apache.org/jira/browse/IMPALA-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Tauber-Marshall resolved IMPALA-4622.
--------------------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.10.0

commit a306096e5665467b9525967441aa44eaee227130
Author: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Date:   Tue May 16 10:46:08 2017 -0700

    IMPALA-4622: Add ALTER COLUMN statement.
    
    Kudu recently added the ability to alter a column's default value
    and storage attributes (KUDU-861). This patch adds the ability to
    modify these from Impala using ALTER.
    
    It also supports altering a column's comment for non-Kudu tables.
    
    It does not support setting a column to be a primary key or
    changing a column's nullability, because those are not supported on
    the Kudu side yet.
    
    Syntax:
    ALTER TABLE <table> ALTER [COLUMN] <column>
      SET <attr> <value> [<attr> <value> [<attr> <value>...]]
    where <attr> is one of:
      - DEFAULT, BLOCK_SIZE, ENCODING, COMPRESSION (Kudu tables)
      - COMMENT (non-Kudu tables)
    ALTER TABLE <table> ALTER [COLUMN] <column> DROP DEFAULT
    
    This is similar to the existing CHANGE statement:
    ALTER TABLE <table> CHANGE <column> <new_col_name> <type>
      [COMMENT <comment>]
    but the new syntax is more natural for setting column properties
    when the column name and type are not being changed. Both ALTER
    COLUMN and CHANGE COLUMN operations use AlterTableAlterColStmt and
    are sent to the catalog as ALTER_COLUMN operations.
    
    Testing:
    - Added FE tests to ParserTest and AnalyzeDDLTest
    - Added EE tests to test_kudu.py
    
    Change-Id: Id2e8bd65342b79644a0fdcd925e6f17797e89ad6
    Reviewed-on: http://gerrit.cloudera.org:8080/6955
    Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com>
    Tested-by: Impala Public Jenkins

> Support changing Kudu default and storage attributes
> ----------------------------------------------------
>
>                 Key: IMPALA-4622
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4622
>             Project: IMPALA
>          Issue Type: New Feature
>          Components: Frontend
>    Affects Versions: Impala 2.8.0, Impala 2.9.0
>            Reporter: Matthew Jacobs
>            Assignee: Thomas Tauber-Marshall
>              Labels: kudu
>             Fix For: Impala 2.10.0
>
>
> Add Impala support for:
> {code}
> KUDU-861 Support changing default, storage attributes
> This patch adds support for adding, changing, or removing column defaults
> and changing the storage attributes of a column. Changes to a column are
> encoded as a ColumnSchemaDelta, which can be merged with a ColumnSchema
> to change it.
> Changing type and nullability of a column is still unsupported.
> No failures in 100+ iterations of alter_table-randomized-test.
> I also ran into an issue with altering RLE columns:
> 1. Add an RLE-encoded column to a table
> 2. Alter the column
> 3. Scan the column
> 3 will cause a check failure on scanning to pos 0 of an empty RLE
> block. Test and fix included.
> Change-Id: I457d99ba2188ef6e439df47c0d94f2dc1a62ea6c
> Reviewed-on: http://gerrit.cloudera.org:8080/4310
> Tested-by: Kudu Jenkins
> Reviewed-by: Dan Burkert <danburkert@apache.org>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message