impala-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Behm (JIRA)" <j...@apache.org>
Subject [jira] [Created] (IMPALA-5341) File size filter in planner tests also filters row-size
Date Fri, 19 May 2017 04:37:05 GMT
Alexander Behm created IMPALA-5341:
--------------------------------------

             Summary: File size filter in planner tests also filters row-size
                 Key: IMPALA-5341
                 URL: https://issues.apache.org/jira/browse/IMPALA-5341
             Project: IMPALA
          Issue Type: Bug
          Components: Infrastructure
    Affects Versions: Impala 2.5.0, Impala 2.6.0, Impala 2.7.0, Impala 2.8.0
            Reporter: Alexander Behm


In our planner tests we want to ignore minor differences in reported file sizes to avoid flaky
tests, see IMPALA-2565. However, the introduced filter also matches "row-size=" which we do
not want to filter.

Relevant code is in TestUtils.java:
{code}
  static class FileSizeFilter implements ResultFilter {
    private final static String BYTE_FILTER = "[KMGT]?B";
    private final static String NUMBER_FILTER = "\\d+(\\.\\d+)?";
    private final static String FILTER_KEY = "size="; <-- also matches "row-size="

    public boolean matches(String input) { return input.contains(FILTER_KEY); }

    public String transform(String input) {
      return input.replaceAll(FILTER_KEY + NUMBER_FILTER + BYTE_FILTER, FILTER_KEY);
    }
  }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message