impala-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (IMPALA-4873) run_test_case() should find/replace arbitrary strings in /testdata/workloads/*/queries/*.test
Date Tue, 09 May 2017 11:27:04 GMT

     [ https://issues.apache.org/jira/browse/IMPALA-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars Volker resolved IMPALA-4873.
---------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.9.0


IMPALA-5287: Test skip.header.line.count on gzip

This change fixed IMPALA-4873 by adding the capability to supply a dict
'test_file_vars' to run_test_case(). Keys in this dict will be replaced
with their values inside test queries before they are executed.

Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70
Reviewed-on: http://gerrit.cloudera.org:8080/6817
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Tested-by: Impala Public Jenkins

> run_test_case() should find/replace arbitrary strings in /testdata/workloads/*/queries/*.test
> ---------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-4873
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4873
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 2.8.0
>            Reporter: David Knupp
>            Assignee: Lars Volker
>              Labels: remote_cluster_test, test-infra, testability
>             Fix For: Impala 2.9.0
>
>
> E.g. this test in query_test/test_kudu.py...
> {code}
> @pytest.mark.execute_serially
> def test_kudu_alter_table(self, vector, unique_database):
>     self.run_test_case('QueryTest/kudu_alter', vector, use_db=unique_database)
> {code}
> ...contains hardcoded values for {{kudu.master_addresses}}:
> {code}
> ====
> ---- QUERY
> # Alter master address to a different location
> alter table simple set tblproperties (
>   'kudu.master_addresses' = 'localhost'
> )
> ---- RESULTS
> 'Updated table.'
> ---- TYPES
> STRING
> ====
> ---- QUERY
> # Show that new address is picked up
> describe formatted simple
> ---- RESULTS: VERIFY_IS_SUBSET
> '','kudu.master_addresses','localhost           '
> ---- TYPES
> STRING,STRING,STRING
> ====
> ---- QUERY
> alter table simple set tblproperties ('kudu.master_addresses' = '127.0.0.1')
> ---- RESULTS
> 'Updated table.'
> ---- TYPES
> STRING
> {code}
> There's no way currently to make this test run on remote clusters because there's no
way to replace the hardcoded values.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message